Skip to content

ref(react-router): Remove stale @opentelemetry/instrumentation dependency - #22826

Merged
andreiborza merged 1 commit into
developfrom
ab/js-3209-remove-stale-react-router-otel
Jul 29, 2026
Merged

ref(react-router): Remove stale @opentelemetry/instrumentation dependency#22826
andreiborza merged 1 commit into
developfrom
ab/js-3209-remove-stale-react-router-otel

Conversation

@andreiborza

@andreiborza andreiborza commented Jul 29, 2026

Copy link
Copy Markdown
Member

What

Remove the unused @opentelemetry/instrumentation dependency from @sentry/react-router.

Why

Nothing in the package imports it. React Router server spans come from the framework's own instrumentation API, and the server-side OTel InstrumentationBase was already removed. @opentelemetry/api stays (still used by createServerInstrumentation).

Closes: #22776

…ency

Nothing in `@sentry/react-router` imports `@opentelemetry/instrumentation`;
server framework spans come from the React Router instrumentation API. Drop
the unused dependency.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Jul 29, 2026

Copy link
Copy Markdown

JS-3209

@andreiborza
andreiborza marked this pull request as ready for review July 29, 2026 13:18
@andreiborza
andreiborza requested a review from a team as a code owner July 29, 2026 13:18
@andreiborza
andreiborza requested review from chargome and s1gr1d and removed request for a team July 29, 2026 13:18
@andreiborza
andreiborza enabled auto-merge (squash) July 29, 2026 13:18

@chargome chargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ay dios, gracias tío

no lockfile changes?

@andreiborza

Copy link
Copy Markdown
Member Author

The node sdk still has @opentelemetry/instrumentation. Once that's gone, lockfile will change.

@andreiborza
andreiborza merged commit 25b66c5 into develop Jul 29, 2026
51 checks passed
@andreiborza
andreiborza deleted the ab/js-3209-remove-stale-react-router-otel branch July 29, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove stale @opentelemetry/instrumentation dependency from @sentry/react-router

3 participants